Skip to content

read workdir from git.config as referenced in man 1 git-config #801

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

read workdir from git.config as referenced in man 1 git-config #801

wants to merge 1 commit into from

Conversation

Farom
Copy link
Contributor

@Farom Farom commented Sep 28, 2018

The setting in .git/config for GIT_WORK_TREE were ignored.
I tried to implement this as git-config says.

@codecov-io
Copy link

codecov-io commented Sep 28, 2018 •
edited
Loading

Codecov Report

Merging #801 into master will decrease coverage by 0.46%.
The diff coverage is 83.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #801      +/-   ##
==========================================
- Coverage   94.71%   94.25%   -0.47%     
==========================================
  Files          59       59              
  Lines        9369     9374       +5     
==========================================
- Hits         8874     8835      -39     
- Misses        495      539      +44
Impacted Files Coverage Δ
git/repo/base.py 95.36% <83.33%> (-0.85%) ⬇️
git/test/test_util.py 90.07% <0%> (-8.52%) ⬇️
git/test/test_base.py 96.42% <0%> (-2.39%) ⬇️
git/objects/submodule/base.py 92.89% <0%> (-1.46%) ⬇️
git/test/test_submodule.py 97.89% <0%> (-1.35%) ⬇️
git/test/lib/helper.py 90.69% <0%> (-1.17%) ⬇️
git/test/test_repo.py 97.24% <0%> (-0.65%) ⬇️
git/cmd.py 83.4% <0%> (-0.44%) ⬇️
git/test/test_docs.py 99.6% <0%> (-0.4%) ⬇️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a8591a0...47f45cf. Read the comment docs.

@Farom Farom force-pushed the worktree_from_config branch from 7da0303 to 47f45cf Compare September 28, 2018 18:36
@Byron
Copy link
Member

Byron commented Oct 13, 2018

Thanks a lot for your contribution! It's much appreciated.
I also added a comment about something puzzling, maybe you can have a look.
Thank you

@Byron
Copy link
Member

Byron commented Oct 21, 2018

One change request was made, after which this PR can be merged. See the resolved conversation in git/repo/base.

@fscherf fscherf mentioned this pull request Nov 8, 2018
Merged
@Byron
Copy link
Member

Byron commented Sep 28, 2019

Thanks a lot for your contribution thus far !
I am closing this PR due to prolonged inactivity. Please feel free to reopen it in case it can proceed.

@Byron Byron closed this Sep 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Byron Byron Byron left review comments

@ukleinek ukleinek ukleinek left review comments

Assignees
No one assigned
Labels
waiting for feedback
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Farom @codecov-io @Byron @ukleinek